Repository navigation
Conversation
 [Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryText fields stay read-only during remote navigation and become editable on activation or physical typing. The latest change preserves native validation messages after an invalid submission.
No new actionable issues were found. Tests were inspected, not run. Reviews (6) · Last reviewed commit: "fix(tv): preserve native form validation..." · Reviewed by Greptile |
![greptile-apps[bot]](/_dp/https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
3abccc9 to
94b64f9
Compare
|
@greptileai review |
3700351 to
9844d74
Compare
Text inputs gained focus read-only so arrowing through forms no longer summons the IME on every field; Enter or click inside the box starts editing and blur restores read-only. Read-only controls are barred from constraint validation, so guarded fields unlock when a form submits and required checks still refuse empty values. A shared backspaceEdits/editingText predicate makes every back layer — remote nav, dialogs, settings panels, player intents — treat Backspace and caret keys as navigation on read-only fields and as text entry only while editing.
|
@greptileai review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2179 +/- ##
========================================
Coverage 81.52% 81.52%
========================================
Files 1875 1875
Lines 97993 98070 +77
Branches 22864 23608 +744
========================================
+ Hits 79885 79949 +64
- Misses 11107 11109 +2
- Partials 7001 7012 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
@greptileai review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](/_dp/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8298a161b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
Text inputs on the TV app no longer summon the on-screen keyboard when the user merely arrows through a form. Fields gain focus read-only; pressing OK/Enter or clicking inside the box starts editing, and blur restores read-only for the next pass.
installImeGuardin@iptvnator/tv/uiarms text-like inputs (text,url,password,search,number,email,tel,textarea) as read-only on focus; activation refocuses so firmwares that only summon the IME on a focus transition still open the keyboard.requiredchecks still run and can refuse empty values.backspaceEdits/editingTextpredicate in@iptvnator/tv/utilunifies the previously divergent "Backspace in an input" carve-outs: remote navigation,TvDialog, settings panels, and player back-intents now all treat Backspace and caret keys as navigation on read-only fields and as text entry only while editing — previously a read-only Backspace inside a picker dialog reached the page's back action instead of closing the dialog.Why
On Tizen, focusing an editable input always opens the IME, so every text field on the way through a form popped the keyboard up and down — settings pages with several fields were tedious to cross.
Testing
libs/tv/testing/platform.test.ts: focus stays read-only, Enter/click activates, blur re-arms, Enter inside an editable field stays native, submit attempts unlock required fields for validation,backspaceEditsseparates deletion from navigation, non-text input types are not guarded.Release note
.changes/Checks
pnpm nx lint/typecheckon affected projects pass;pnpm nx run tv:test— 189/190 (1 pre-existing environment failure unrelated to this change:build-info.test.mjsneeds Node ≥22.23 for.tsimports)