Repository navigation
[UI] Hide the Saves-Sync Quick on the game page menu behind a setting - #5323
Merged
Merged
Conversation
flavioislima
requested review from
BananaWorks07,
CommandMC,
arielj and
imLinguin
February 16, 2026 17:13
flavioislima
added
the
pr:ready-for-review
arielj
reviewed
Feb 16, 2026
arielj
left a comment
arielj
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine, just some comments to de-duplicate things (I'm sure it will be easy to forget in the future that we have the same component coded in 2 places)
Member
Author
|
Deduplicated the code so we have one single component now |
CommandMC
reviewed
Feb 17, 2026
| onClick={() => handleSync(command.value as SyncType)} | ||
| disabled={ | ||
| (gameInfo.runner === 'legendary' && savesPath === '') || | ||
| (gameInfo.runner === 'gog' && gogSaves.length === 0) |
Member
There was a problem hiding this comment.
I don't think this conditional is correct. Wouldn't you also have to check whether there is a path set for any of the GOG-provided save files? So
// Instead of `gogSaves.length === 0`
... && !gogSaves.any((save) => save.location))
Member
Author
There was a problem hiding this comment.
good catch, will fix it. Although, for some reason it is working, but could be edge cases.
arielj
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new setting to disable in case someone doesn't like it and also to fix some edge cases:
Use the following Checklist if you have changed something on the Backend or Frontend: