Skip to content

[FIX] Fix inconcistent login state switching stores - #5383

Merged
arielj merged 1 commit into
mainfrom
fix-inconsistent-store-login-state
Mar 13, 2026
Merged

arielj merged 1 commit into
mainfrom
fix-inconsistent-store-login-state

Conversation

@arielj

@arielj arielj commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes #5257

The issue was that we use different partitions for the webview and when react re-renders the page it does NOT change the partition if the webview is already rendered. So starting with a store sets a partition and then changing to another store keeps the previous partition, but when changing to another screen and going back to stores, the webview is rendered from scratch and the partition is set.

This PR adds the key attribute so whenever we change the store, the webview is completely re-rendered, setting the correct partition.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj
arielj requested review from a team, BananaWorks07, CommandMC, biliesilva, flavioislima and imLinguin and removed request for a team March 1, 2026 01:40
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 1, 2026
@arielj arielj added this to the 2.21 milestone Mar 10, 2026

@flavioislima flavioislima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj
arielj merged commit 792067d into main Mar 13, 2026
9 checks passed
@arielj
arielj deleted the fix-inconsistent-store-login-state branch March 13, 2026 15:17
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

store credentials used inconsistently

2 participants