Repository navigation
[Fix] "Copy to clipboard" button in system info page - #5529
Merged
Merged
Conversation
CommandMC
requested review from
BananaWorks07,
arielj,
biliesilva,
flavioislima and
imLinguin
and removed request for
a team
April 26, 2026 14:15
CommandMC
added
the
pr:ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The button did not work, as the
onClickhandler passed theMouseEventonto the backend listener. Trying to copy the event (to pass it between the processes) did not work. I assume something changed in the MouseEvent structure between Electron versions, as the button of course worked in the past.To test: Open Heroic without the patch, open "Settings" -> "System Information", click the "Copy to clipboard" button. Observe an error in the console/log, and the info not being copied. Open this PR's version, issue no longer occurs.
Closes #5526
Use the following Checklist if you have changed something on the Backend or Frontend: