Skip to content

fix(gog): keep library entries when GamesDB is unavailable - #5798

Merged
flavioislima merged 1 commit into
Heroic-Games-Launcher:mainfrom
xianjianlf2:fix/gog-gamesdb-fallback-5797
Sep 15, 2026
Merged

flavioislima merged 1 commit into
Heroic-Games-Launcher:mainfrom
xianjianlf2:fix/gog-gamesdb-fallback-5797

Conversation

@xianjianlf2

Copy link
Copy Markdown
Contributor

Summary

  • keep GOG library entries when GamesDB metadata is unavailable after retries
  • fall back to the existing GOG product API for title, artwork, description, installability, and platform metadata
  • preserve the existing behavior for GamesDB entries that are not visible library games
  • add unit coverage for product metadata conversion

Fixes #5797

Validation

  • pnpm test:ci (22 suites, 136 tests)
  • pnpm codecheck
  • pnpm exec prettier --check src/backend/storeManagers/gog/library.ts src/backend/storeManagers/gog/unified_info.ts src/backend/storeManagers/gog/tests/unified_info.test.ts
  • git diff --check

@flavioislima

flavioislima commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@xianjianlf2

Copy link
Copy Markdown
Contributor Author

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.感谢您的提交,我们非常感激。与许多开源项目一样,我们要求您在提交贡献之前签署我们的贡献者许可协议 (CLA) 。您只需按照以下格式在 Pull Request 中发表评论即可签署 CLA。

I have read the CLA Document and I hereby sign the CLA我已阅读 CLA 文件,并在此签署 CLA 文件。

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

I have read the CLA Document and I hereby sign the CLA

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 3, 2026
@flavioislima
flavioislima requested review from a team, BananaWorks07, CommandMC, arielj, biliesilva, flavioislima and imLinguin and removed request for a team August 3, 2026 13:50
@flavioislima

Copy link
Copy Markdown
Member

@xianjianlf2 you really just need to answer with that text

@xianjianlf2

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@xianjianlf2

Copy link
Copy Markdown
Contributor Author

recheck

Signed-off-by: MarkXian <mark-xian@foxmail.com>
@xianjianlf2

Copy link
Copy Markdown
Contributor Author

已同步最新 upstream/main(原分支落后 3 个提交)并重新验证。全量 test:ci 22 suites / 136 tests 通过;codecheck 通过;改动文件 Prettier 通过。请维护者 review。

@xianjianlf2
xianjianlf2 force-pushed the fix/gog-gamesdb-fallback-5797 branch from c5640fa to 573e286 Compare August 7, 2026 02:51
@flavioislima
flavioislima merged commit dd50768 into Heroic-Games-Launcher:main Sep 15, 2026
10 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Sep 15, 2026
@flavioislima

Copy link
Copy Markdown
Member

Thanks @xianjianlf2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GOG: gamesdb 502 for GWENT (1971477531) silently drops game from library

2 participants