Skip to content

fix: Make sure to set Wine-related options when adding a sideloaded game - #5827

Merged
CommandMC merged 1 commit into
Heroic-Games-Launcher:mainfrom
CommandMC:fix/sideload-wine-options-again
Sep 9, 2026
Merged

CommandMC merged 1 commit into
Heroic-Games-Launcher:mainfrom
CommandMC:fix/sideload-wine-options-again

Conversation

@CommandMC

Copy link
Copy Markdown
Member

In #5599, I had assumed that setWinePrefix, setWineVersion and setCrossoverBottle are useSetting return values, and thus, setting them will automatically save the set option for the game. However...

const [winePrefix, setWinePrefix] = useState('...')
const [wineVersion, setWineVersion] = useState<WineInstallation>()
const [wineVersionList, setWineVersionList] = useState<WineInstallation[]>([])
const [crossoverBottle, setCrossoverBottle] = useState('')

...they are not. Thus, we have to make sure to save them when the user clicks "Finish" in the dialog.

Closes #5820


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added this to the 2.23.0 milestone Aug 15, 2026
@CommandMC CommandMC self-assigned this Aug 15, 2026
@CommandMC
CommandMC requested a review from a team as a code owner August 15, 2026 17:08
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 15, 2026

@arielj arielj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine 👍

I think it would be nice, at some point in the future, to be able to send the settings in the handleInstall call, but that's out of the scope of this

@CommandMC
CommandMC merged commit 7c17f2a into Heroic-Games-Launcher:main Sep 9, 2026
10 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Sep 9, 2026
@CommandMC
CommandMC deleted the fix/sideload-wine-options-again branch September 9, 2026 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heroic using shared prefix no matter what i do

2 participants