Repository navigation
Conversation
CommandMC
requested review from
BananaWorks07,
arielj,
biliesilva,
flavioislima and
imLinguin
August 15, 2026 17:08
arielj
approved these changes
Sep 3, 2026
arielj
left a comment
Collaborator
There was a problem hiding this comment.
Seems to be working fine 👍
I think it would be nice, at some point in the future, to be able to send the settings in the handleInstall call, but that's out of the scope of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5599, I had assumed that
setWinePrefix,setWineVersionandsetCrossoverBottleareuseSettingreturn values, and thus, setting them will automatically save the set option for the game. However...HeroicGamesLauncher/src/frontend/screens/Library/components/InstallModal/index.tsx
Lines 49 to 52 in 3492444
...they are not. Thus, we have to make sure to save them when the user clicks "Finish" in the dialog.
Closes #5820
Use the following Checklist if you have changed something on the Backend or Frontend: