Repository navigation
test: refactor container_list_linux_test.go to use Tigron - #5058
Merged
AkihiroSuda merged 1 commit intoJul 18, 2026
Merged
AkihiroSuda merged 1 commit into
AkihiroSuda merged 1 commit into
Conversation
sathiraumesh
suggested changes
Jul 10, 2026
| // CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES SIZE | ||
| // be8d386c991e docker.io/library/busybox:latest "top" 1 second ago Up c1 16.0 KiB (virtual 1.3 MiB) | ||
| testCase.Setup = func(data test.Data, helpers test.Helpers) { | ||
| setupPsTestContainer(data, helpers, "list", true) |
Contributor
There was a problem hiding this comment.
Remove the extra lines and do formatting correctly
Contributor
Author
There was a problem hiding this comment.
Hi, @sathiraumesh I've removed the extra lines and formatted well, please re-review.
| return fmt.Errorf("expect container size %s, but got %s", expectedSize, size) | ||
| image, _ := tab.ReadRow(lines[1], "IMAGE") | ||
| assert.Equal(t, image, testutil.CommonImage) | ||
|
|
Contributor
There was a problem hiding this comment.
extra lines and there are in many places
Signed-off-by: Daniel Benjamin <benjamindaniel706@gmail.com>
papidb
force-pushed
the
test/refactor-container-list-linux-test-to-tigron
branch
from
July 10, 2026 14:45
aeb2b2e to
33a1850
Compare
46 tasks done
AkihiroSuda
requested review from
haytok and
sathiraumesh
and removed request for
sathiraumesh
July 14, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite tests in container_list_linux_test.go from testutil.NewBase to nerdtest.Setup (Tigron framework). Part of #4613.