Repository navigation
Mode: don't activate Smart just from opening the Always charge dropdown - #34264
Merged
Merged
Conversation
Opening the chevron dropdown immediately switched the loadpoint to Smart mode with whatever Always charge value was left over from a previous session, before the user could change it. Move the Smart activation into the dropdown's toggle handler instead, so it only triggers on an actual change.
![sourcery-ai[bot]](/_dp/https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Member
|
Good fix! Now Smart is activated when changing a setting inside the dropdown but now as soon as opening it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #34263
Opening the chevron that reveals the "Always charge" dropdown called
ensureSmart()on click, which immediately switches the loadpoint toSmartmode (posting to the backend) before the dropdown's toggle can even be touched. Because "Always charge" is a persistent per-loadpoint setting that survives mode switches, this re-activates charging with whatever value was left over from a previous session — e.g. sending an unwanted wakeup — before the user gets a chance to turn it off.This moves the
ensureSmart()call out of the chevron's click handler and into the dropdown's own toggle handler (updateAlwaysCharge), so opening the dropdown only lets you inspect/change "Always charge"; switching toSmartnow only happens when you actually interact with the toggle.🤖 Generated with Claude Code