[andig]

fixes #35100

VW delivers two mileage.value entries in random order. Name lookup picks whichever comes first, so the odometer jumps between the current and a stale value. Key 69d437d3 tracks the app according to the reporter and is now looked up first.

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've found 2 issues

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="vehicle/vw/eudataact/provider.go" line_range="136" />
<code_context>
 	}

-	if p := lookup(data, FieldOdometer, FieldOdometerValue); p != nil {
+	if p := lookup(data, KeyMileageValue, FieldOdometer, FieldOdometerValue); p != nil {
 		return strconv.ParseFloat(p.Value, 64)
 	}
</code_context>
<issue_to_address>
**Stale mileage overrides current reading**

When both the current-key point and a fallback mileage point are present, and the fallback has a higher `Seq`, `lookup` compares `Seq` across matches before honoring the exact-key match, so the fallback overrides the current-key point and `Odometer` returns stale mileage.

Prioritize the exact-key point over fallback name matches, regardless of `Seq`.
</issue_to_address>

### Comment 2
<location path="vehicle/vw/eudataact/provider.go" line_range="136" />
<code_context>
 	}

-	if p := lookup(data, FieldOdometer, FieldOdometerValue); p != nil {
+	if p := lookup(data, KeyMileageValue, FieldOdometer, FieldOdometerValue); p != nil {
 		return strconv.ParseFloat(p.Value, 64)
 	}
</code_context>
<issue_to_address>
**Invalid mileage prevents fallback**

When the preferred-key point has a nonnumeric value while a fallback mileage point has a valid value, `Odometer` parses only the selected point and returns its parse error, so a malformed value for the preferred key masks a valid fallback mileage and the caller gets no odometer reading.

Try the remaining matching mileage points if parsing the preferred point fails, and return an error only if none parse successfully.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook