Repository navigation
Conversation
…ithin the container
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a problem with icons alignemnt in many documentations using the theme. For example in urllib3 documentation we have like this for example (do check this out in the browser):


and for accute eyes it's obvious that the icons are not well aligned to the center, though after adding
align-items: center(using for example in my case chrome devtools) we get this:still not aligned yet, though after inspection that's because the intermediary html tags sitting between the svgs and the
.content-icon-containerget slightly different increasing heights at each level (do check this out with the devtools), so for example in our case here for the eye svg, its height is different from its parent<a> tagwhich is even more different from the parentdiv.view-this-page, but adding this rule fixes this problem entirelyas this makes sure that all intermediary nested html sitting between the svgs and the
.content-icon-containerdon't change height valuesNow after adding this rule we finally get good alignement (you'll notice the icon shifting after adding rule in devtools)

This fix will make sure that no weird alignement behaviors happen with the icons, like in this case with qt for python documentation